feat(tiering): Decoders #5883
Open
feat(tiering): Decoders #5883
+201
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
force-pushed
the
tiering-decoders
branch
3 times, most recently
from
64ac01b to
1905a87
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
tiering-decoders
branch
from
1905a87 to
1f6f4a5
Compare
dranikpg
commented
Oct 5, 2025
Comment on lines
+22
to
+23
| // Poor man's type-erasure copy | ||
| virtual std::unique_ptr<Decoder> Clone() const = 0; |
There was a problem hiding this comment.
- Either this, so the caller can pass a decoder by value, or the caller has to pass a function creating an encoder
- I don't want to use unique_ptrs later, I want to initialize in place with proper align to avoid allocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how support for multiple datatypes will look like